Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Creating CustomMetrics for Rust CustomEvents #3188

Merged
merged 33 commits into from
Jun 21, 2023
Merged

Creating CustomMetrics for Rust CustomEvents #3188

merged 33 commits into from
Jun 21, 2023

Conversation

nharper285
Copy link
Contributor

@nharper285 nharper285 commented Jun 13, 2023 •
edited
Loading

Summary of the Pull Request

What is this about?
New CustomMetrics for the following rust events:

  • task_start,
  • coverage_data,
  • coverage_failed,
  • new_result,
  • new_coverage,
  • runtime_stats,
  • new_report,
  • new_unique_report,
  • new_unable_to_reproduce,
  • regression_report,
  • regression_unable_to_reproduce,

PR Checklist

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023 •
edited
Loading

Codecov Report

Merging #3188 (49be939) into main (fda68ac) will increase coverage by 2.72%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3188      +/-   ##
==========================================
+ Coverage   29.52%   32.25%   +2.72%     
==========================================
  Files         332      180     -152     
  Lines       39068    22819   -16249     
==========================================
- Hits        11535     7360    -4175     
+ Misses      27533    15459   -12074
Impacted Files Coverage Δ
src/agent/onefuzz-task/src/tasks/config.rs 0.00% <0.00%> (ø)
...c/agent/onefuzz-task/src/tasks/coverage/generic.rs 0.00% <0.00%> (ø)
...nt/onefuzz-task/src/tasks/fuzz/libfuzzer/common.rs 21.03% <0.00%> (-0.45%) ⬇️
...gent/onefuzz-task/src/tasks/report/crash_report.rs 12.50% <0.00%> (-0.27%) ⬇️
src/agent/onefuzz-telemetry/src/lib.rs 2.43% <0.00%> (-0.16%) ⬇️
src/agent/onefuzz/src/syncdir.rs 10.39% <0.00%> (-0.16%) ⬇️

... and 152 files with indirect coverage changes

nharper285 added 26 commits June 13, 2023 23:11
@nharper285
Syntax.
e8a0770
@nharper285
Merge branch 'user/noharper/rust-metrics' of https://github.com/nharp…
5b00931 
…er285/onefuzz into user/noharper/rust-metrics
@nharper285
syntax.
780db08
@nharper285
Trying something else.
b4020f4
@nharper285
Playing around with new metric function:
fd3ca48 
:
@nharper285
Trying new format
dd80ab6
@nharper285
Merge branch 'main' into user/noharper/rust-metrics
8be6915
@nharper285
Fixing arguments.
65189fd
@nharper285
Merge branch 'user/noharper/rust-metrics' of https://github.com/nharp…
9732ce0 
…er285/onefuzz into user/noharper/rust-metrics
@nharper285
Importing metrics
f977d12
@nharper285
Reverting to events
758bff3
@nharper285
Removing
7ff201c
@nharper285
Adding.
013d3f7
@nharper285
Changing to int.
c65a786
@nharper285
Changing back to float.
781f1c5
@nharper285
Adding metric lines for all events.
dca5e97
@nharper285
trying to set.
b57c4e1
@nharper285
Fixing.
cf2ed19
@nharper285
Merge branch 'main' into user/noharper/rust-metrics
1e7d8da
@nharper285
Adding copy.
3fb5682
@nharper285
Merge branch 'user/noharper/rust-metrics' of https://github.com/nharp…
58baf0d 
…er285/onefuzz into user/noharper/rust-metrics
@nharper285
Was this a problem..
c152084
@nharper285
Adding different.
f0cbea6
@nharper285
Solution for all.
5a46e64
@nharper285
Another.
af0e342
@nharper285
removing
6e707f8
@nharper285 nharper285 marked this pull request as ready for review June 17, 2023 00:19
@nharper285 nharper285 changed the title Adding initial metric. Creating CustomMetrics for Rust CustomEvents Jun 17, 2023
@mgreisen
Copy link
Contributor

Are there additional tests for the new code?

@nharper285
Copy link
Contributor Author

Are there additional tests for the new code?

Not currently. I'll check and see if we have existing tests for the event logging that I can work off of.

@nharper285 nharper285 requested a review from chkeita June 20, 2023 17:29
@nharper285 nharper285 merged commit 7716a81 into microsoft:main Jun 21, 2023
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jun 21, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chkeita chkeita chkeita approved these changes

@Porges Porges Porges approved these changes

@ranweiler ranweiler Awaiting requested review from ranweiler

@stishkin stishkin Awaiting requested review from stishkin

@mgreisen mgreisen Awaiting requested review from mgreisen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nharper285 @codecov-commenter @mgreisen @Porges @chkeita